Skip to content

Update jennyf/b2cwebapi from latest jmprieur/webappwebapib2c (and therefore master) #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 10, 2020

Conversation

jmprieur
Copy link
Contributor

Purpose

This PR attempts to update jennyf/b2cwebapi

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

A sync from latest changes and PR accepted since last week

[x] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code

bgavrilMS and others added 15 commits January 29, 2020 14:33
# Conflicts:
#	Microsoft.Identity.Web/AuthorizeForScopesAttribute.cs
* Updated references to 3.1.1
* Handle trailing slash and 'v2.0' in configured Authority value in AddProtectedWebApi method.
* Only add api:// to valid audiences if given as Client Id (not beginning with 'api://'.
* Handle optional configured ending slash for Instance in `TokenAcquisition`
Missing AuthenticatedClient in GetMyMemberOfGroupsAsync()
* Adding unit tests to #278
and reverting the UI package upgrade as 3.1.1 has a bug

* Undoing what the refactoring tools in VS have changed

* Updating the AzureADxx.UI packages

* Adressing PR comments
@jmprieur jmprieur requested a review from jennyf19 February 10, 2020 16:24
@jmprieur
Copy link
Contributor Author

@jennyf19. this PR aims at bringing to your B2C branch the changes done this week (done since you created your branch), including merging PRs from customers, a couple of unit tests, bug fixes in term of references in particular.

Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19
Copy link
Contributor

@jmprieur thanks so much. appreciated. :)


In reply to: 584208876 [](ancestors = 584208876)

@jennyf19 jennyf19 merged commit b931371 into jennyf/b2cwebapi Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants